Pinging this..

> -----Original Message-----
> From: Richard Wai <rich...@annexi-strayline.com>
> Sent: March 16, 2021 2:19 PM
> To: 'gcc-patches@gcc.gnu.org' <gcc-patches@gcc.gnu.org>
> Cc: 'Arnaud Charlet' <char...@adacore.com>; 'Bob Duff'
> <d...@adacore.com>
> Subject: RE: [PATCH] Ada: hashed container Cursor type predefined equality
> non-conformance
> 
> Just a note that I do not have write access, so I will need someone who
does
> to commit this patch, if approved.
> 
> Richard
> 
> > -----Original Message-----
> > From: Richard Wai <rich...@annexi-strayline.com>
> > Sent: March 11, 2021 9:13 AM
> > To: 'Arnaud Charlet' <char...@adacore.com>
> > Cc: 'gcc-patches@gcc.gnu.org' <gcc-patches@gcc.gnu.org>; 'Bob Duff'
> > <d...@adacore.com>
> > Subject: RE: [PATCH] Ada: hashed container Cursor type predefined
> > equality non-conformance
> >
> > Here is the amended commit log:
> >
> > --
> >
> > Ada: Ensure correct predefined equality behavior for Cursor objects of
> > hashed containers.
> >
> > 2021-03-11  Richard Wai  <rich...@annexi-strayline.com>
> >
> > gcc/ada/
> >     * libgnat/a-cohase.ads (Cursor): Synchronize comments for the
> Cursor
> >     type definition to be consistent with identical definitions in other
> >     container packages. Add additional comments regarding the
> importance
> > of
> >     maintaining the "Position" component for predefined equality.
> >     * libgnat/a-cohama.ads (Cursor): Likewise.
> >     * libgnat/a-cihama.ads (Cursor): Likewise.
> >     * libgnat/a-cohase.adb (Find, Insert): Ensure that Cursor objects
> >     always have their "Position" component set to ensure predefined
> >     equality works as required.
> >     * libgnat/a-cohama.adb (Find, Insert): Likewise.
> >     * libgnat/a-cihama.adb (Find, Insert): Likewise.
> >
> > gcc/testsuite/
> >     * gnat.dg/containers2.adb: New test.
> >
> > --
> >
> > Thanks!
> >
> > Richard
> >
> > > -----Original Message-----
> > > From: Arnaud Charlet <char...@adacore.com>
> > > Sent: March 10, 2021 11:27 AM
> > > To: Richard Wai <rich...@annexi-strayline.com>
> > > Cc: gcc-patches@gcc.gnu.org; 'Bob Duff' <d...@adacore.com>; Arnaud
> > > Charlet <char...@adacore.com>
> > > Subject: Re: [PATCH] Ada: hashed container Cursor type predefined
> > > equality non-conformance
> > >
> > > > I'm not sure I correctly understand you here, but my
> > > > interpretation is that I should no longer submit Changelog
> > > > entries, rather just the patch, and then
> > >
> > > Right.
> > >
> > > > a commit message (a-la git), and then presumably the Changelong
> > > > entries will be generated automatically. From what I can see, gcc'
> > > > website does not talk about that, so I'm guessing this format
> > > > based on what I see from git-log, generally.
> > > >
> > > > So assuming that, attached is the "correct" patch, and here is the
> > > > commit
> > > > message:
> > > >
> > > > ---
> > > >
> > > > Author: Richard Wai <rich...@annexi-strayline.com>
> > > >
> > > > Ada: Ensure correct Cursor predefined equality behavior for hashed
> > > > containers.
> > > >
> > > > --
> > > >
> > > > And for the record, the change log entries I've come up with as
> > > > per the previous email:
> > >
> > > And the commit log will look like:
> > >
> > > 2021-03-09  Richard Wai  <rich...@annexi-strayline.com>
> > >
> > > gcc/ada/
> > >   * libgnat/...
> > >
> > > gcc/testsuite/
> > >   * gnat.dg/containers2.adb: ...
> > >
> > > Your patch is OK with these changes, thanks.

Reply via email to