> -----Original Message----- > From: Arnaud Charlet <char...@adacore.com> > Sent: March 10, 2021 10:23 AM > To: Richard Wai <rich...@annexi-strayline.com> > Cc: gcc-patches@gcc.gnu.org; 'Bob Duff' <d...@adacore.com>; Arnaud > Charlet <char...@adacore.com> > Subject: Re: [PATCH] Ada: hashed container Cursor type predefined equality > non-conformance > > > I appologise for making a mess of this final step. I have leared the > > errors of my ways. > > > By the way, ChangeLog are automatically generated these days, so we're > really talking about commit logs and diffs against ChangeLog (as you did in > your previous email) are no longer appropriate (and almost never apply > anyway). >
I'm not sure I correctly understand you here, but my interpretation is that
I should no longer submit Changelog entries, rather just the patch, and then
a commit message (a-la git), and then presumably the Changelong entries will
be generated automatically. From what I can see, gcc' website does not talk
about that, so I'm guessing this format based on what I see from git-log,
generally.
So assuming that, attached is the "correct" patch, and here is the commit
message:
---
Author: Richard Wai <rich...@annexi-strayline.com>
Ada: Ensure correct Cursor predefined equality behavior for hashed
containers.
--
And for the record, the change log entries I've come up with as per the
previous email:
--
gcc/ada/Changelog:
2021-03-09 Richard Wai <rich...@annexi-strayline.com>
* libgnat/a-cohase.ads (Cursor): Synchronize comments for the Cursor
type definition to be consistent with identical definitions in other
container packages. Add additional comments regarding the importance
of
maintaining the "Position" component for predefined equality.
* libgnat/a-cohama.ads (Cursor): Likewise.
* libgnat/a-cihama.ads (Cursor): Likewise.
* libgnat/a-cohase.adb (Find, Insert): Ensure that Cursor objects
always have their "Position" component set to ensure predefined
equality works as required.
* libgnat/a-cohama.adb (Find, Insert): Likewise.
* libgnat/a-cihama.adb (Find, Insert): Likewise.
gcc/testsuite/Changelog:
2021-03-09 Richard Wai <rich...@annexi-strayline.com>
* gnat.dg/containers2.adb: New test.
--
I've learned a lot, and appreciate your time.
Richard
container_cursor_equality_20210304.patch
Description: Binary data
