Oops, I wrote "effected" when I meant "affected". Of course, despite reading it several times before sending, I only noticed it after sending.
Edited version: --- * libgnat/a-cohase.ads, libgnat/a-cohase.adb, libgnat/a-cohama.ads, libgnat/a-cohama.adb, libgnat/a-cihama.ads, libgnat/a-cihama.adb: Ensure that Cursor objects always have their "Position" component set to ensure predefined equality works as required; synchronize comments for the Cursor type defintion across affected packages, and add comments to explain the importance of updating the Position component. * testsuite/gnat.dg/containers2.adb: New regression test to ensure that all hashed containers obey predefined equality requirements for Cursor objects. --- > -----Original Message----- > From: Richard Wai <rich...@annexi-strayline.com> > Sent: March 9, 2021 10:35 AM > To: 'Arnaud Charlet' <char...@adacore.com> > Cc: 'gcc-patches@gcc.gnu.org' <gcc-patches@gcc.gnu.org>; 'Bob Duff' > <d...@adacore.com> > Subject: RE: [PATCH] Ada: hashed container Cursor type predefined equality > non-conformance > > Hey Arno, > > I forgot that last time as well! How about this: > > --- > > * libgnat/a-cohase.ads, libgnat/a-cohase.adb, libgnat/a-cohama.ads, > libgnat/a-cohama.adb, libgnat/a-cihama.ads, libgnat/a-cihama.adb: > Ensure that Cursor objects always have their "Position" component set to > ensure predefined equality works as required; synchronize comments for > the Cursor type defintion across effected packages, and add comments to > explain the importance of updating the Position component. > * testsuite/gnat.dg/containers2.adb: New regression test to ensure that all > hashed containers obey predefined equality requirements for Cursor > objects. > > --- > > Thanks for your speedy review! > > Richard > > > -----Original Message----- > > From: Arnaud Charlet <char...@adacore.com> > > Sent: March 9, 2021 3:12 AM > > To: Richard Wai <rich...@annexi-strayline.com> > > Cc: gcc-patches@gcc.gnu.org; Arnaud Charlet <char...@adacore.com>; Bob > > Duff <d...@adacore.com> > > Subject: Re: [PATCH] Ada: hashed container Cursor type predefined > > equality non-conformance > > > > Richard, > > > > Your patch is missing a corresponding commit log. > > > > Can you please add it to your submission? Otherwise your test and > > patch look good so far, thanks! > > > > Arno > > > > > We discovered an issue with the GNAT implementation of the hashed > > > container types.
