On 1/10/20 9:34 AM, Tobias Burnus wrote:
I believe except for bugs and known omissions (e.g. PR93225+93226), the
GCC 10 trunk implementation is complete – and the version number can be
bumped from 2.0 (alias 201306) to OpenACC 2.6 (alias 201711).
That's what this patch does (i.e. applying the previously mentioned OG9
patch).
It also includes the previous patch, i.e. the addition of the missing
acc_*_async and acc_*_finalize prototypes.
Additionally, I added the missing documentation for
acc_attach/acc_detach. — And I did not include the following wording,
which the OG9 patch added: "This list has not yet been updated for the
OpenACC specification in version 2.6."
OK for the trunk?
My only comment on this patch relates to this hunk:
diff --git a/gcc/fortran/gfortran.texi b/gcc/fortran/gfortran.texi
index 4cf8b3a5c24..2ef9c22da66 100644
--- a/gcc/fortran/gfortran.texi
+++ b/gcc/fortran/gfortran.texi
@@ -546,10 +546,8 @@ status} and @ref{Fortran 2018 status} sections of the
documentation.
Additionally, the GNU Fortran compilers supports the OpenMP specification
(version 4.0 and most of the features of the 4.5 version,
@url{http://openmp.org/@/wp/@/openmp-specifications/}).
-There also is initial support for the OpenACC specification (targeting
-version 2.0, @uref{http://www.openacc.org/}).
-Note that this is an experimental feature, incomplete, and subject to
-change in future versions of GCC. See
+There also is support for the OpenACC specification (targeting
+version 2.6, @uref{http://www.openacc.org/}). See
@uref{https://gcc.gnu.org/wiki/OpenACC} for more information.
@node Varying Length Character Strings
I happen to have noticed a couple weeks ago that this language about
OpenACC support being experimental appears in multiple places in the
gfortran manual, including in the description of the -fopenacc
command-line option. The same disclaimer for that option in the main
GCC manual was removed years ago, so unless the Fortran support is much
more broken than the C/C++ support, I think it ought to be removed from
the Fortran manual as well. It looks like there are 3 instances in
gfortran.texi and 1 in invoke texi.
The other documentation changes in this patch look trivial to me, but
again I'm not the right person to review for content.
-Sandra
