On 1/8/20 9:07 AM, Tobias Burnus wrote:
When looking at libgomp.texi the other day, I saw that the acc_*_async variants and the acc_*_finalize functions of OpenACC 2.5 were not documented.

Hence, this patch adds them. Those are part of OpenACC 2.5, hence, I updated the @ref (but referenced to OpenACC 2.6 instead).

Possible variants:
(a) update all acc_* calls to OpenACC 2.6 @refs
(b) defer updating the @ref until the OpenACC version is bumped from 2.0 (alias 201306) to OpenACC 2.6 (alias 201711). [Cf. OG9 branch's 7a22697197b85931d9fda66e8b0f75171ea13b43] (c) Independent of the @ref: write the variable-type declarations for Fortran en bloc after all the "subroutine" as they are the same – especially useful for acc_copyout* which has 8 variants. That's how OpenACC 2.7's spec does it.

Regarding (c): If one goes for that change, does one keep the "INTERFACE" string in the table for each "subroutine" line? And what do to about the variable-declaration lines? Adding a single "ARGUMENTS" before the first of those (i.e. in the "a" line)?

Comments, suggestions, approval?

From a docs point of view, this patch looks OK to me as-is, but I don't really have enough state on what is being documented here to comment on the content and organization questions you've raised. :-(

-Sandra

Reply via email to