> When looking at the rs6000_store_data_bypass_p stuff, I've noticed that
> it accepts PARALLELs containing not just SETs and CLOBBERs like
> store_data_bypass_p, but also USEs.  Given that it is something that
> single_set also ignores, I think fixing store_data_bypass_p is the
> right fix here.
> 
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> 
> Note, the patch is larger due to the formatting fixes, the actual changes
> are just 3x
> -             if (GET_CODE (xxx) == CLOBBER)
> +             if (GET_CODE (xxx) == CLOBBER || GET_CODE (xxx) == USE)

Couldn't the code be also re-factored?  Because 3x the same change is a lot...

> 2017-12-06  Jakub Jelinek  <ja...@redhat.com>
> 
>       * recog.c (store_data_bypass_p): Handle USE in a PARALLEL
>       like CLOBBER.  Formatting fixes.

OK for mainline modulo the above remark.

-- 
Eric Botcazou

Reply via email to