On Fri, Sep 16, 2016 at 09:12:42AM +0200, Rainer Orth wrote:
> Excess errors:
> cc1: error: strategy name 'rep_8byte' specified for option
> '-mmemcpy_strategy=' not supported for 32-bit code
>
> > --- gcc/config/i386/i386.c.jj 2016-09-06 16:55:35.524605779 +0200
> > +++ gcc/config/i386/i386.c 2016-09-06 19:45:03.126299652 +0200
> [...]
> > @@ -4555,9 +4555,25 @@ ix86_parse_stringop_strategy_string (cha
> >
> > if (i == last_alg)
> > {
> > - error ("wrong stringop strategy name %s specified for option %s",
> > - alg_name,
> > - is_memset ? "-mmemset_strategy=" : "-mmemcpy_strategy=");
> > + error ("wrong strategy name %qs specified for option %qs",
> > + alg_name, opt);
>
> The message lost the "stringop" ...
That was intentional, I think it is fine to use the term stringop internally in
gcc,
but it isn't something we should present to users.
> > --- gcc/testsuite/gcc.target/i386/pr65990.c.jj 2016-09-05
> > 19:27:03.016674736 +0200
> > +++ gcc/testsuite/gcc.target/i386/pr65990.c 2016-09-06 17:47:11.812776172
> > +0200
> > @@ -1,7 +1,7 @@
> > /* { dg-do compile } */
> > /* { dg-options "-mtune=btver2 -mmemcpy-strategy=rep_8byte:-1:noalign" }
> >
> > -/* { dg-error "stringop strategy name rep_8byte specified for option
> > -mmemcpy_strategy= not supported for 32-bit code" "" { target ia32 } 0 } */
> > +/* { dg-error "stringop strategy name 'rep_8byte' specified for option
> > '-mmemcpy_strategy=' not supported for 32-bit code" "" { target ia32 } 0 }
> > */
>
> ... while the testcase still requires it. Can't tell for certain which
> is intended.
Dunno how I've managed to mess this up, and certainly I saw this FAIL last
night, meant to look at it in the morning.
Here is what I've committed.
2016-09-16 Jakub Jelinek <ja...@redhat.com>
PR middle-end/77475
* gcc.target/i386/pr65990.c: Adjust dg-error regexp.
--- gcc/testsuite/gcc.target/i386/pr65990.c.jj 2016-09-15 14:25:51.000000000
+0200
+++ gcc/testsuite/gcc.target/i386/pr65990.c 2016-09-16 10:10:15.745196917
+0200
@@ -1,7 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-mtune=btver2 -mmemcpy-strategy=rep_8byte:-1:noalign" }
-/* { dg-error "stringop strategy name 'rep_8byte' specified for option
'-mmemcpy_strategy=' not supported for 32-bit code" "" { target ia32 } 0 } */
+/* { dg-error "strategy name 'rep_8byte' specified for option
'-mmemcpy_strategy=' not supported for 32-bit code" "" { target ia32 } 0 } */
struct U9
{
Jakub
