Hi Jakub,
> 2016-09-05 Jakub Jelinek <ja...@redhat.com>
>
> PR middle-end/77475
> * config/i386/i386.c (ix86_parse_stringop_strategy_string): Simplify,
> use %qs instead of %s where desirable, use argument instead of arg in
> the diagnostic wording, add list of supported strategies and
> spellcheck hint.
> (ix86_option_override_internal): Emit target("m...") instead of
> option("m...") in the diagnostic. Use %qs instead of %s in invalid
> -march/-mtune option diagnostic. Add list of supported arches/tunings
> and spellcheck hint. Remove prefix, suffix and sw variables, use
> main_args_p ? "..." : "..." in diagnostics to make translation
> possible.
>
> * gcc.target/i386/pr65990.c: Adjust expected diagnostics.
this test now fails on 32-bit Solaris/x86:
FAIL: gcc.target/i386/pr65990.c (test for errors, line )
FAIL: gcc.target/i386/pr65990.c (test for excess errors)
Excess errors:
cc1: error: strategy name 'rep_8byte' specified for option '-mmemcpy_strategy='
not supported for 32-bit code
> --- gcc/config/i386/i386.c.jj 2016-09-06 16:55:35.524605779 +0200
> +++ gcc/config/i386/i386.c 2016-09-06 19:45:03.126299652 +0200
[...]
> @@ -4555,9 +4555,25 @@ ix86_parse_stringop_strategy_string (cha
>
> if (i == last_alg)
> {
> - error ("wrong stringop strategy name %s specified for option %s",
> - alg_name,
> - is_memset ? "-mmemset_strategy=" : "-mmemcpy_strategy=");
> + error ("wrong strategy name %qs specified for option %qs",
> + alg_name, opt);
The message lost the "stringop" ...
> --- gcc/testsuite/gcc.target/i386/pr65990.c.jj 2016-09-05
> 19:27:03.016674736 +0200
> +++ gcc/testsuite/gcc.target/i386/pr65990.c 2016-09-06 17:47:11.812776172
> +0200
> @@ -1,7 +1,7 @@
> /* { dg-do compile } */
> /* { dg-options "-mtune=btver2 -mmemcpy-strategy=rep_8byte:-1:noalign" }
>
> -/* { dg-error "stringop strategy name rep_8byte specified for option
> -mmemcpy_strategy= not supported for 32-bit code" "" { target ia32 } 0 } */
> +/* { dg-error "stringop strategy name 'rep_8byte' specified for option
> '-mmemcpy_strategy=' not supported for 32-bit code" "" { target ia32 } 0 } */
... while the testcase still requires it. Can't tell for certain which
is intended.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
