On Mon, Sep 05, 2016 at 07:54:15PM -0400, David Malcolm wrote:
> The calls into spellcheck.h are minimal and look reasonable (I can't
> really comment on the x86 aspects). So I have little to add beyond the
> cleanups that Manu already observed.
>
> One thing: shouldn't this have testcases that give test coverage for
> emitting hints for -march and -mtune? Something like
> gcc/testsuite/gcc.dg/spellcheck-options-11.c
> (though obviously the new ones would be target-specific).
I guess I could add one, but would prefer not to list all the CPUs, just
perhaps few first ones, because otherwise whenever a new CPU is added we'll
need to adjust the testcase.
Jakub
