On Mon, Aug 15, 2011 at 11:57 AM, Richard Sandiford <rdsandif...@googlemail.com> wrote:
>>> Following on from the two patches I've just posted, this one makes >>> config/i386/*.md use match_test for .md attributes. Tested as >>> described here: >> >>> http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01182.html >> >>> * config/i386/i386.md: Use (match_test ...) for attribute tests. >>> * config/i386/mmx.md: Likewise. >>> * config/i386/sse.md: Likewise. >> >> - (eq (symbol_ref "TARGET_SSE2") (const_int 0))) >> + (not (match_test "TARGET_SSE2"))) >> >> Jus a question - in predicates.md, i.e. (match_test "!TARGET_SSE2") is >> used. Do we want to standardize on (not (match_test "...")) form >> everywhere? > > Yeah, good question. I'd used (not (match_test ...)) so that genattrtab > could better optimise combinations of expressions. I suppose we don't > yet combine predicate expressions in the same way, so it probably makes > no difference there. We might use predicate expressions more in future > though. > > I'm happy to convert predicate match_tests at the same time. That would be much appreciated. Thanks, Uros.
