On 05/20/2016 03:44 PM, Eric Botcazou wrote:
So here's that cleanup. The diffs are larger than one might expect
because of the reindentation that needs to happen. So I've included a
-b diff variant which shows how little actually changed here.
I'm wondering if it isn't counter-productive. The ??? comment is explicit
about where the problem comes from: STACK_POINTER_OFFSET used to be defined
only when needed, now it's always defined.
So I think that we should try to restore the initial state, this will very
likely generate fewer alignment operations, for example:
I pondered that as a direction, but was scared off by the overall
fragility of this code when I looked back through the old BZs. I
figured cleanup preserving existing behavior was the first step.
We can go the other way if you prefer. It just makes reasoning about
how this code is supposed to work harder.
jeff
