> So here's that cleanup. The diffs are larger than one might expect > because of the reindentation that needs to happen. So I've included a > -b diff variant which shows how little actually changed here.
I'm wondering if it isn't counter-productive. The ??? comment is explicit about where the problem comes from: STACK_POINTER_OFFSET used to be defined only when needed, now it's always defined. So I think that we should try to restore the initial state, this will very likely generate fewer alignment operations, for example: #if defined (STACK_DYNAMIC_OFFSET) if (1) #else if (STACK_POINTER_OFFSET) #endif { must_align = true; extra_align = BITS_PER_UNIT; } -- Eric Botcazou