On Tue, Jun 21, 2016 at 04:26:03PM -0600, Jeff Law wrote: > On 06/21/2016 03:35 AM, Dominik Vogt wrote: > >What do we do now with the two patches? At the moment, the > >functional patch depends on the changes in the cleanup patch, so > >it cannot be applied on its own. Options: > > > >(with the requested cleanup in the functional patch) > > > > 1) Apply both patches as they are now and do further cleanup on > > top of it. > > 2) Rewrite the functional patch so that it applies without the > > cleanup patch and commit it now. > > 3) Look into the suggested cleanup now and adapt the functional > > patch to it when its ready. > > > >Actually I'd prefer (1) or (2) to just get the functional patch > >off my desk. I agree that the cleanup is very useful, but there's > >not relation between the cleanup and the functional stuff except > >that they touch the same code. Having the functional patch > >applied would simplify further work for me. > I thought Eric had ack'd the cleanup patch with a comment fix, so > that can move forward and presumably unblock your functional patch. > Right? > > So I think the TODO here is for me to fix the comment per Eric's > review so that you can move forward. The trick is getting it done > before I go on PTO at the end of this week :-)
The comment fix is part of the version of the cleanup patch I posted, but I've removed some more dead code. I can handle all of this if I know what to do exactly. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany
