Hi Andrew,
On 16 Oct 2015, at 20:49, Andrew MacLeod wrote:
> On 10/12/2015 04:04 AM, Jeff Law wrote:
>> On 10/08/2015 07:37 AM, Andrew MacLeod wrote:
>>> On 10/07/2015 06:02 PM, Jeff Law wrote:
>>
>> I'm slightly concerned about the darwin, windows and solaris bits. The
>> former primarily because Darwin has been a general source of pain, and in
>> the others because I'm not sure the cross testing will exercise that code
>> terribly much.
>>
>> I'll go ahead and approve all the config/ bits. Please be on the lookout
>> for any fallout.
>>
>> I'll try and get into more of the other patches tomorrow.
>>
>>
>
> OK, I've checked in the config changes. I rebuilt all the cross compilers
> for the 200+ targets, and they still build.. as well as bootstrapping on
> x86_64-pc-linux-gnu with no regressions.
>
> So. If any one runs into a native build issue you can either add the required
> header back in, or back out the file for your port, and I'll look into why
> something happened. The only thing I can imagine is files that have
> conditional compilation based on a macro that is only ever defined on a
> native build command line or headers. Its unlikely... but possible.
I've applied the following to fix Darwin native bootstrap.
AFAICT (from reading the other thread on the re-ordering tools) putting the
diagnostics header at the end of the list is the right thing to do.
FWIW,
a) of course, Darwin exercises ObjC/ObjC++ in *both* NeXT and GNU mode - so
those are pretty well covered by this too.
b) darwin folks will usually do their best to test any patch that you think is
specifically risky - but you need to ask, because we have (very) limited
resources in time and hardware ;-) ...
thanks for tidying things up!
(I, for one, think that improving the separation of things is worth a small
amount of pain along the way).
cheers,
Iain
gcc/
+2015-10-18 Iain Sandoe <i...@codesourcery.com>
+
+ * config/darwin-driver.h: Adjust includes to add diagnostic-core.
+
2015-10-16 Trevor Saunders <tbsaunde+...@tbsaunde.org>
* lra-constraints.c (add_next_usage_insn): Change argument type
Index: gcc/config/darwin-driver.c
===================================================================
--- gcc/config/darwin-driver.c (revision 228938)
+++ gcc/config/darwin-driver.c (working copy)
@@ -23,6 +23,7 @@
#include "coretypes.h"
#include "tm.h"
#include "opts.h"
+#include "diagnostic-core.h"
#ifndef CROSS_DIRECTORY_STRUCTURE
#include <sys/sysctl.h>
