On 14/10/15 10:54, Jakub Jelinek wrote:
On Tue, Oct 13, 2015 at 07:54:33PM +0300, Maxim Ostapenko wrote:
On 13/10/15 14:15, Maxim Ostapenko wrote:
This is the raw merge itself. I'm bumping SONAME to libasan.so.3.
-Maxim
I have just noticed that I've misused autoconf stuff (used wrong version).
Here a fixed version of the same patch. Sorry for inconvenience.
Is libubsan, libtsan backwards compatible, or do we want to change SONAME
there too?
No, they are not (for UBSan heuristic doesn't work well for GCC, TSan
has some type changes into interceptors and data structures, e.g. in
struct ReportStack). I can share more details, if desired.
The aarch64 changes are terrible, not just because it doesn't yet have
runtime decision on what VA to use or that it doesn't support 48-bit VA,
but also that for the 42-bit VA it uses a different shadow offset from
39-bit VA. But on the compiler side we have just one...
Though, only the 39-bit VA is enabled right now by default, so out of the
box the state is as bad as we had in 5.x - users wanting 42-bit VA or 48-bit
VA have to patch libsanitizer.
Have you verified libbacktrace sanitization still works properly (that is
something upstream does not test)?
I'm sorry, didn't catch well your words about libbacktrace sanitization.
Did you mean symbolization? If so, I didn't perform any special
validation here (thought output patterns tests use libbacktrace output,
no?). But I wonder how can I verify this more or less automatically.
Do you plan to update the asan tests we have to reflect the changes in
upstream?
Hm, there aren't changes into instrumentation, so the only thing is new
interceptors. If it is desirable, I can migrate some tests for new
interceptors from upstream.
Jakub
