tsoome added a comment.
I think we should really keep both 66 and 150. But also definitely we should point out in docs that in case of option 66, the ip address should be used, as in current code, we do not have name resolver. This does add some more complications to the validation and feedback. INLINE COMMENTS > rgrimes wrote in bootp.c:443 > You marked this as done but it still only accepts a dotted quad, if we cant > process a hostname here maybe that is why Bapt used option 150? As a > minimum add a comment saying there is a known bug here with not processing a > hostname, maybe /* XXX Should accept hostname as well as dotted quad */ it should be clear error message for user. if you are attempting your netboot, then digging in source for XXX comments is last thing in your mind. REVISION DETAIL https://reviews.freebsd.org/D10485 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp Cc: rgrimes, garga, ler, asomers _______________________________________________ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
