oshogbo added inline comments.
INLINE COMMENTS
> bootp.h:99
> +
> +#define VEND_INFO_END 0xff /* End option in RFC2132 */
>
Let's use 255 instead of hexa value as described in rfc:
> Code 255 (END), if present, signifies the end of the
>
> encapsulated vendor extensions, not the end of the vendor
> extensions field. If no code 255 is present, then the end of
> the enclosing vendor-specific information field is taken as the
> end of the encapsulated vendor-specific extensions field.
Lets also use the file standard:
#define VEND_INFO_END ((unsigned char) 255) /* End option
in RFC2132 */
REVISION DETAIL
https://reviews.freebsd.org/D10485
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp
Cc: rgrimes, garga, ler, asomers
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
