> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Carl Eugen Hoyos > Sent: Monday, January 20, 2020 10:14 PM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use > bit-exact > check for dnn_processing > > Am Mo., 20. Jan. 2020 um 14:25 Uhr schrieb Martin Storsjö > <mar...@martin.st>: > > > Keep in mind that ideally, you shouldn't be changing the reference files > > in the separate samples directory incrementially; ideally they should be > > fairly static. > > Since not everybody is a native speaker: > You cannot change reference files once they are used by fate, they have > to be static and remain where they are.
thanks Carl. Just had a chance to test on IBM PowerPC (big end) and found the new gray float test fails, the reason is that the reference file is generated in little end machine and grayf32 contains 4 bytes. So it makes sense to remove the test for grayf32 format, and only keep rgb24 format. To make the reference file static, my idea is to keep the current fate-filter-dnn_processing-halve_first_channel_float (with reference file) unchanged, and only add a new test once we get a big milestone of dnn_processing. > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
