On 2017-07-25 08:33, Yogender Gupta wrote:
I can push, but to answer Timo's question: I did not add P016 to nvenc because it is technically not correct to pass 12bit content through a 10bit surface - that will lead to truncation, rather than dithering. If you are telling us that nvenc supports 12bit >> input and will correctly dither, then great. Otherwise, it's more correct to not support and force dithering to happen through swscale. You could also write cuda accelerated dithering.

I have dropped the NVENC patch for now (we will build a P016 to P010
CUDA dithering filter). Attached the other patches, also taking into
account some code formatting comments.

Thanks,
Yogender

Hi Yogender,

That's great.

Your patches look fine, although they need micro version bumps in libavfilter and libavutil. I've added those to my local copy of the patches, but I know realise I can't push either,
as I'm travelling for another week. I'll push them when I get back.

Thanks,

--phil
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to