On Tue, Oct 04, 2016 at 04:21:29PM -0400, Derek Buitenhuis wrote: > This fixes downconverting framerates to multiples. > > For example, prior to this patch, converting 900 frames at 60 fps > to 30 fps would output 451 frames instead of the correct 450. > > Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> > --- > DISCLAIMER: I don't know libavfilter very well, and I am not > sure this is the correct fix to the problem. Comments definitely > welcome. > > Also, I would be happy if any replies could be CC'd to me.
breaks fate and the change to fate looks wrong, the last frame is lost make fate-filter-fps TEST filter-fps --- ./tests/ref/fate/filter-fps 2016-10-04 14:46:19.642736770 +0200 +++ tests/data/fate/filter-fps 2016-10-04 22:54:01.859353244 +0200 @@ -84,4 +84,3 @@ 0, 78, 78, 1, 30576, 0xa2fcd06f 0, 79, 79, 1, 30576, 0xa2fcd06f 0, 80, 80, 1, 30576, 0xa2fcd06f -0, 81, 81, 1, 30576, 0xd4150aad Test filter-fps failed. Look at tests/data/fate/filter-fps.err for details. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
