On Sat, Mar 26, 2016 at 1:12 AM, Thilo Borgmann <thilo.borgm...@mail.de> wrote: >> >> When you go from talking about a developers concerns to just pushing, >> then how else do you think someone should feel? > > You are again ignoring what I did and what I've written in the previous > mails to explain what I did and why I did it. > Basically you're just repeating that in your opinion I "just pushed". As > long as you don't explain why you think that way with respect to what > I've written there will be no progress in this discussion. > That's a pity because we both are obviously thinking that this is an > important topic. Unfortunately, I think I did what you demand - I pinged > after there was a significant silence after the last review. > It is on you to prove me wrong for convincing me that I made a mistake > by pushing too early.
None of the posts in this thread are a ping, all I see is back and forth between two developers. A ping would generally explictily ask for further feedback after a time of silence, or anything like that, I don't see that here. For all I knew, you were waiting for a response from wm4 on the last mail, it was only a few days ago afterall. This way, it would be clear to everyone reading, and someone else might comment, instead I was thinking wm4 gave criticism, and this would be hashed out before its pushed, especially since the general rule is that when a developer has an issue with a patch, it shouldn't be pushed until he was convinced otherwise or the patch adjusted, if appropriate. This also doesn't answer the question that this patch was never excplicitly OK'ed. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel