On Sun, Jan 24, 2016 at 01:46:50PM -0800, Timothy Gu wrote: > On Sun, Jan 24, 2016 at 10:21:14PM +0100, Andreas Cadhalpun wrote: > > > > That's not very reasonable. > > Other changes also broke things that worked before. > > For example before commit 94c20de one could build ffmpeg with x265 version > > X265_BUILD 17, and afterwards it requires at least X265_BUILD 57. > > That effect is well-known during the review stage, and has been approved by > the community. > > The side effect of your commit, namely, that it will break MSVC, was NOT known > during the review stage (if there was one) of your patches. > > > > > That's also a regression, but the workaround is to use a newer x265 version. > > Well-thought out and approved-by-community regressions are not regressions > that need to be "fixed." >
> This argument also applies to the hwaccel situation: the community is aware of > VLC's using MT during review and with that awareness the patch is passed. hmm Btw, did someone benchmark the MT+hwaccel vs hwaccel minus MT case ? on a system where it works well enough to allow benchmarking ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know the Truth, for even if they happen to say it by chance, they would not even known they had done so. -- Xenophanes
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
