> > You're right, didn't know that. > > Please let me know if there are any changes you want me to apply in order > > to push the third one (decryption support). > > sounds like you missed: > http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/185235.html > http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/185238.html > Correct, I missed it. It's just that I'm not getting any emails from this mailing list (verified they are not getting to the junk folder...). So I've been polling the page of the last message of this thread in ffmpeg.org, and guess these posts were added to a different leaf of the message tree... Would really appreciate it if this could be resolved, either add my work email - eran dot kornblau at kaltura dot com or my personal email - erankor at gmail dot com.
> if you want to maintain the code in the future then please send a > patch that adds you to the maintainers file > Attached > > > + id = mov_codec_id(st, format); > > + st->codec->codec_id = id; > > doesnt this allow changing the codec id to anything from anything ? > this seems potentially risky > I see options to address this: 1. overwrite the codec_id only when it's AV_CODEC_ID_NONE 2. (stricter) save the format 4cc (that is loaded in ff_mov_read_stsd_entries) to some member of MOVStreamContext, and overwrite the codec id only when the format is 'encv' or 'enca' please let me know which one you prefer, and I will update the patch. > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > Thanks a lot, Michael ! Eran
0001-add-Eran-Kornblau-to-maintainers.patch
Description: 0001-add-Eran-Kornblau-to-maintainers.patch
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
