On Mon, Dec 28, 2015 at 09:27:41PM +0000, Eran Kornblau wrote:
> > > + case MKTAG('e','n','c','v'): // encrypted video
> > > + case MKTAG('e','n','c','a'): // encrypted audio
> > > + id = mov_codec_id(st, format);
> > > + st->codec->codec_id = id;
> >
> > this seems missing a check for st->codec->codec_id being "unset"
> > before setting it
> >
> Will add it
> > > > > > + sc->format = format; > > > + break; > > > + > > > + default: > > > + av_log(c->fc, AV_LOG_WARNING, > > > + "ignoring 'frma' atom of '%.4s', stream format is > > > '%.4s'\n", > > > + (char*)&format, (char*)&sc->format); > > > > the way these are printed would lead to different results on big and > > little endian > > > Correct, however it's already done this way in a few other places in this > file (search for %.4s) > Do you prefer that I will print it with %c%c%c%c as in > ff_mov_read_stsd_entries ? whatever way you prefer [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
