On Sat, Oct 3, 2015 at 8:38 AM, Ganesh Ajjanagadde <gajjanaga...@gmail.com> wrote: > On Sat, Sep 26, 2015 at 1:32 PM, Ganesh Ajjanagadde > <gajjanaga...@gmail.com> wrote: >> On Sat, Sep 19, 2015 at 1:00 AM, Ganesh Ajjanagadde >> <gajjanaga...@gmail.com> wrote: >>> Commit 6dac8c8327 disabled av_uninit for clang, due to some useless >>> warnings. >>> The concept of av_uninit is inherently useful though. This patch silences a >>> bunch of warnings on clang e.g >>> http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. >>> Furthermore, it should be useful for general usage of av_uninit in future. >>> >>> Signed-off-by: Ganesh Ajjanagadde <gajjanaga...@gmail.com> >>> --- >>> libavutil/attributes.h | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/libavutil/attributes.h b/libavutil/attributes.h >>> index 50e8eb3..b4b5f13 100644 >>> --- a/libavutil/attributes.h >>> +++ b/libavutil/attributes.h >>> @@ -141,6 +141,12 @@ >>> >>> #if defined(__GNUC__) && !defined(__INTEL_COMPILER) && !defined(__clang__) >>> # define av_uninit(x) x=x >>> +#elif defined(__clang__) >>> +# define av_uninit(x) \ >>> + _Pragma("clang diagnostic push") \ >>> + _Pragma("clang diagnostic ignored \"-Wuninitialized\"") \ >>> + x=x \ >>> + _Pragma("clang diagnostic pop") >>> #else >>> # define av_uninit(x) x >>> #endif >>> -- >>> 2.5.2 >>> >> >> ping > > been a week, hence ping again.
ping: the reason I persist in this is because (long-term) the only 2 compilers where we can reasonably reach a near "warning is regression" state and benefit from it are clang and gcc. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
