On Tue, Aug 27, 2024 at 02:03:37AM +0200, Marton Balint wrote:
> Using INFINITY can cause issues with -ffast-math, and since we only use this
> value to decide the formatting, we can just as easily use 0 for log10 of zero.
>
> Signed-off-by: Marton Balint <c...@passwd.hu>
> ---
> libavutil/timestamp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/timestamp.c b/libavutil/timestamp.c
> index 6c231a517d..be4540d4c8 100644
> --- a/libavutil/timestamp.c
> +++ b/libavutil/timestamp.c
> @@ -24,7 +24,7 @@ char *av_ts_make_time_string2(char *buf, int64_t ts,
> AVRational tb)
> snprintf(buf, AV_TS_MAX_STRING_SIZE, "NOPTS");
> } else {
> double val = av_q2d(tb) * ts;
> - double log = (fpclassify(val) == FP_ZERO ? -INFINITY :
> floor(log10(fabs(val))));
> + double log = (fpclassify(val) == FP_ZERO ? 0 :
> floor(log10(fabs(val))));
> int precision = (isfinite(log) && log < 0) ? -log + 5 : 6;please add a comment as log(0) = 0 is not correct (in the general case) otherwise LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human being will ever know the Truth, for even if they happen to say it by chance, they would not even known they had done so. -- Xenophanes
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
