Quoting Zhao Zhili (2024-07-23 13:44:37) > > On Jul 23, 2024, at 19:35, Martin Storsjö <mar...@martin.st> wrote: > > > > On Wed, 10 Jul 2024, Zhao Zhili wrote: > > > >> > >>> On Jun 12, 2024, at 21:42, Matthieu Bouron <matthieu.bou...@gmail.com> > >>> wrote: > >>> Hello, > >>> This patchset adds Mediacodec audio decoders support. Currently, only > >>> AAC, AMR, > >>> MP3, FLAC, VORBIS and OPUS are supported. > >>> This is mainly useful to avoid shipping Android builds of FFmpeg that are > >>> subjects to licensing/patents (due to AAC and AMR). > >> > >> I’m not keen on put OS audio decoder/encoder wrapper into FFmpeg. They > >> don’t bring new features, they don’t improve performance. I know these > >> type of wrapper exist in current project, but I’m not sure if it’s a good > >> idea to add more. > > > > I don't see a problem with it. It doesn't add much extra code, we already > > have MediaCodec interfacing in place, it allows users to set up whichever > > configuration they want. We have this for other OS codec interfaces as > > well, I don't see a problem with adding this one as well - no need for the > > further arguments about security and sandboxes. > > OK. Security isn’t what I’m concerned. I wasn’t clear on the policy side > concern than technique issues. > > I will do a review and test as soon as possible.
I don't think we should add wrappers for random decoders just because they are there, without a good reason. And if the reason here is patents, then it does not apply to flac, vorbis, or opus. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
