On Thu, Nov 30, 2023 at 11:20 PM Kyle Swanson <k...@ylo.ph> wrote: > Hi, > > On Thu, Nov 30, 2023 at 1:36 PM Paul B Mahol <one...@gmail.com> wrote: > > > > Loudnorm filter is big pile of hacks, I wanted to move forward and I > > improved it. > > > > I received nothing in return just some politics talks. > > > > I will apply this soon unless technical comments arise. > > > > Why would I spend on this more my precious time? For no real gain as I > will > > again > > receive nothing in return except some useless comment and no single > > technical aspect. > > Please don't merge this as-is. I'm sure there are good changes/fixes > here that we should merge, but you need to help your reviewers > understand what is going on. One big commit that combines both > refactoring across files with introduction of new filter behavior is > very hard to review. That's why I'm suggesting we do this in two > steps, I think Anton's suggestion is the same. >
But how you could refactor code if one filter shares nothing with another filter code? Its not possible. You all seem to not understand problem at all. > > Thanks, > Kyle > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
