On Mon, 8 Mar 2021, Michael Niedermayer wrote:

On Mon, Mar 08, 2021 at 09:56:38PM +0100, Marton Balint wrote:


On Sun, 7 Mar 2021, Michael Niedermayer wrote:

On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote:
If the window is resized it was possible that xpos pointed outside the
visualization texture. By rearranging the overflow check we make sure this (and
a crash) does not happen.


We also don't have to use xleft for start position, as that is 0 anyways, and
if we ever want to take into account xleft then the texture should be
positioned accordingly when rendering.

reading this, i wonder if a assertion with xleft == 0 would make sense

I don't really see the point.

It was just an idea that came to my mind without any deep thoughts


I'd rather add the xleft/ytop to the render if
you prefer, but overall I don't think it matters.

please do what you prefer!

Ok, thanks, pushed as is then.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to