On Wed, 2015-01-14 at 14:28 -0500, Paul Smith wrote: > Actually, looking at this more it seems like you can set the > BOGOFILTER environment variable to any value and it's used verbatim > without checking if it exists.
I did create the patch below while looking at things... it allows one to give "--enable-bogofilter=/usr/bin/bogofilter" on the configure command line instead of setting BOGOFILTER (the previous behaviours are all preserved as well). Just in case someone likes that better... and since I already did it :) (Technically it's not necessary to use the x$var trick with case; it's a shell keyword (unlike test); it's always worked to say 'case $var in' even if $var is empty... but I followed the convention in the rest of configure.ac).
diff --git a/configure.ac b/configure.ac index a2148ab..1b0bcf9 100644 --- a/configure.ac +++ b/configure.ac @@ -1052,6 +1052,18 @@ AC_ARG_ENABLE([bogofilter], [AS_HELP_STRING([--enable-bogofilter], [enable spam filtering using Bogofilter (default=yes)])], [enable_bogofilter=$enableval], [enable_bogofilter=yes]) +case x"$enable_bogofilter" in +xyes) + : ok + ;; +xno) + : ok + ;; +*) + BOGOFILTER=$enable_bogofilter + enable_bogofilter=yes + ;; +esac AC_MSG_CHECKING([if Bogofilter support is enabled]) AC_MSG_RESULT([$enable_bogofilter]) msg_bogofilter="$enable_bogofilter"
_______________________________________________ evolution-list mailing list evolution-list@gnome.org To change your list options or unsubscribe, visit ... https://mail.gnome.org/mailman/listinfo/evolution-list