Bert Burgemeister <tre...@googlemail.com> writes: > Just curious, is there anything I should have known that prevented the > patch submitted in http://article.gmane.org/gmane.emacs.orgmode/39313,
Is it still in the bugtracker, or was it rejected? (I attempted to check myself, but the patchwork site seems to be down right now.) There has been a cascade of patches on the list recently (I plead guilty to adding my fair share), and there aren't many people who are authorized to push to the repo. With your patch, what would happen if there were two or more links in the headline? * Two links %%(format "%s" (concat "[[elisp:(info)]" "[Link to info]]")) http://www.orgmode.org This entry would show up in the agenda as: org: [[elisp:(info)][Link to info]] But AFAICT, hitting C-c C-o in the agenda-buffer (even on the elisp link) would jump immediately to http://www.orgmode.org, bypassing the opportunity to select the the %%(...) generated link. Best, Matt >> From: Bert Burgemeister <tre...@googlemail.com> >> Subject: [O] [PATCH] Bugfix: org-agenda-open-link >> Newsgroups: gmane.emacs.orgmode >> To: emacs-orgmode@gnu.org >> Date: Sun, 13 Mar 2011 16:18:44 +0100 >> >> >> * Org-agenda.el (org-agenda-open-link): C-c C-o didn't open links >> inserted via the `%%( )' mechanism, affecting usability of >> `%%(org-bbdb-anniversaries). >> >> TINYCHANGE >> --- >> >> >> The bug was apparently introduced in commit >> ba1e90893d128d8004e4cb6763af692c5a6cd677. >> >> -- >> Bert >> >> >> >> lisp/org-agenda.el | 14 +++++++------- >> 1 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el >> index 4b4dd68..123668c 100644 >> --- a/lisp/org-agenda.el >> +++ b/lisp/org-agenda.el >> @@ -6742,13 +6742,13 @@ at the text of the entry itself." >> (+ (point-at-bol) >> (or (org-get-at-bol 'prefix-length) 0))))) >> (cond >> - (buffer >> - (with-current-buffer buffer >> - (save-excursion >> - (save-restriction >> - (widen) >> - (goto-char marker) >> - (org-offer-links-in-entry arg prefix))))) >> + ((and buffer >> + (with-current-buffer buffer >> + (save-excursion >> + (save-restriction >> + (widen) >> + (goto-char marker) >> + (org-offer-links-in-entry arg prefix)))))) >> ((or (org-in-regexp (concat "\\(" org-bracket-link-regexp "\\)")) >> (save-excursion >> (beginning-of-line 1) >> -- >> 1.7.2.3 > > from being noticed?
