Strange, I rebased onto main, cleaned out all of the .elc files, and re-ran
and it passes:

 make test BTEST_RE="test-org/org-timestamp-change-dst"
...
Running 1 tests (2026-04-16 06:16:14-0600, selector
‘"test-org/org-timestamp-change-dst"’)
   passed  1/1  test-org/org-timestamp-change-dst (0.001709 sec)

Ran 1 tests, 1 results as expected, 0 unexpected (2026-04-16 06:16:14-0600,
0.001880 sec)

I tried running a full "make test" but the Python tests hang, is that a
known issue?

Thanks,

Derek

On Sun, Apr 12, 2026 at 12:53 AM Ihor Radchenko <[email protected]> wrote:

> Derek Chen-Becker <[email protected]> writes:
>
> > Here's the updated patch based on the recommendations. One note about
> > behavior for the fall back time (e.g. EDT 2025-11-02 1:59): the current
> > behavior for fall back doesn't wrap, but I think that's actually OK. If
> we
> > wrapped at the transition from 1:59 -> 1:00 then org-shiftup would
> > basically get trapped at that boundary and couldn't go past it. I think
> the
> > current behavior of 1:55 -> 2:00 makes sense because unlike the
> > spring-forward case, the shift can't result in an invalid time.
>
> Thanks!
> I tried to run the tests, but I get the new test failing:
>
> Test test-org/org-timestamp-change-dst condition:
>     (ert-test-failed
>      ((should-error
>        (org-test-with-temp-text "<2026-03-08 Sun 03:00>"
>          (org-timestamp-change -1 ...) :type 'user-error))
>       :form
>       (let ((--inside-text ...) (org-mode-hook nil))
>         (let (...) (save-current-buffer ... ...)))
>       :value user-error :fail-reason "did not signal an error"))
>    FAILED  1362/1464  test-org/org-timestamp-change-dst (0.001596 sec) at
> ../lisp/test-org.el:9539
>
> > +     ;; Testing the fall-back DST transition [2025-11-02 1:59] ->
> [2025-11-02 2:00]
>
> *2:00 -> 1:00
>
> --
> Ihor Radchenko // yantar92,
> Org mode maintainer,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>


-- 
+---------------------------------------------------------------+
| Derek Chen-Becker                                             |
| GPG Key available at https://keybase.io/dchenbecker and       |
| https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org |
| Fngrprnt: EB8A 6480 F0A3 C8EB C1E7  7F42 AFC5 AFEE 96E4 6ACC  |
+---------------------------------------------------------------+

Reply via email to