Derek Chen-Becker <[email protected]> writes:
> Here's the updated patch based on the recommendations. One note about
> behavior for the fall back time (e.g. EDT 2025-11-02 1:59): the current
> behavior for fall back doesn't wrap, but I think that's actually OK. If we
> wrapped at the transition from 1:59 -> 1:00 then org-shiftup would
> basically get trapped at that boundary and couldn't go past it. I think the
> current behavior of 1:55 -> 2:00 makes sense because unlike the
> spring-forward case, the shift can't result in an invalid time.
Thanks!
I tried to run the tests, but I get the new test failing:
Test test-org/org-timestamp-change-dst condition:
(ert-test-failed
((should-error
(org-test-with-temp-text "<2026-03-08 Sun 03:00>"
(org-timestamp-change -1 ...) :type 'user-error))
:form
(let ((--inside-text ...) (org-mode-hook nil))
(let (...) (save-current-buffer ... ...)))
:value user-error :fail-reason "did not signal an error"))
FAILED 1362/1464 test-org/org-timestamp-change-dst (0.001596 sec) at
../lisp/test-org.el:9539
> + ;; Testing the fall-back DST transition [2025-11-02 1:59] ->
> [2025-11-02 2:00]
*2:00 -> 1:00
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
