>>> Explicit numbering is required because some images will fail to be >>> generated, and we will get off-by-one and other index errors when >>> matching the input fragment ↔ output image otherwise. >>> >>> What should I do here about the compatibility? It seems like it should >>> be okay to break this. > > Still the same comment. > > %O is "absolute output file name" > There is nothing stopping us from > doing spec = > (?O . ,(shell-quote-argument > (concat (expand-file-name texfile-base temporary-file-directory) > "%09d.png")) >
I need to think about this. >>>> We should then also get rid of >>>> (define-obsolete-function-alias 'org-remove-latex-fragment-image-overlays >>>> 'org-clear-latex-preview "9.3") >>>> That's now super-obsolete. >>> >>> Removed. >> >> I do not see it in git, but note that we also need to announce the >> removal in news. > > I see it on git now, but still need to announce in the news. Done. >>>>> (define-obsolete-function-alias >>>>> 'org--get-display-dpi 'org-latex-preview--get-display-dpi "9.7") >>>> >>>> This is redundant. There is no need to obsolete internal functions. >>> >>> I believe I kept this in because some external packages (like PDF tools) >>> were using it. But I have removed it now. > > If PDF tools is still using it, we can keep it. But add a commend why we > do it. I'm leaving it removed. >>>>> (define-obsolete-function-alias >>>>> 'org-latex-mathml-directory 'org-mathml-export-directory "9.8") >>>> >>>> Obsoletion not announced in the news. >>>> Also, org-mathml-export-directory is ignored in the new code. >>> >>> I haven't fixed this. I'm not familiar with this code, not sure what >>> the idea is here. I'll ask Timothy. > > Please also note an email from Jacob. ox-odt creates links to files > generated by ox-mathml. If those files are in temporary directory, we > are breaking ox-odt. I'll investigate this when looking at ox-odt. > We need to remove earlier obsoletion here as well: > (define-obsolete-variable-alias 'org-latex-preview-ltxpng-directory > 'org-preview-latex-image-directory "9.0") > > (and announce in the news) > > Also, > | ~org-preview-latex-image-directory~ | ~org-latex-preview-cache~ > | > in the news is no longer accurate. Please update that table and update > the news according to the new reshuffling of obsolete alias vs. obsolete > variable. Both done. Karthik
