Karthik Chikmagalur <[email protected]> writes: >> - (or (assq 'read-process-output-max process-variables) >> read-process-output-max) >> is not consistent with the docstring. The docstring hard-codes 65536 > > I've fixed it to look like a let-binding instead. 65536 is the default > value in Emacs 30, I think that's why we used that in the documentation.
> + :process-variables > + ((process-adaptive-read-buffering process-adaptive-read-buffering) > + (process-connection-type process-connection-type) > + (read-process-output-max read-process-output-max)) You added this, but process-connection-type/adaptive-read-buffering are hard-coded to default to nil. >> (apply #'start-process >> (format "org-async-%s-%d" >> (car proc) (cl-incf org-async--counter)) >> buffer proc) >> but the docstring says >> "...a list run using `start-process' with the car as the command and the cdr >> as the arguments." >> Nothing about BUFFER. > > I don't think anything needs to be said about BUFFER here? The fact > that start-process is called with BUFFER as its buffer argument is an > implementation detail, and the meaning of BUFFER is covered further down > in the docstring. I see why I was confused. I thought that "arguments" are `start-process' arguments, not command arguments. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
