Ihor Radchenko <[email protected]> writes:
>> I can modify org-html-prepare-latex-images so that
>> org-format-latex-options is respected:
>> ...
>
> Discussed off-list. Pending.
This is done now.
>>>> (define-obsolete-variable-alias
>>>> 'org-format-latex-header 'org-latex-preview-preamble "9.7")
>>>
>>> This is not just obsoletion. The value have been changed.
>>> We need to keep the old value, singling out the old variable.
>>> Otherwise, the obsolete `org-create-formula-image' will stop working.
>>
>> Done, I've restored the variable's original value and marked it
>> obsolete.
>
> Not done yet on your branch. Pending.
Also done now.
>>> Will the entries from org-latex-preview-process-alist work with
>>> `org-create-formula-image'? I think they will not. In particular
>>> old ("dvipng -D %D -T tight -o %O %f") is not compatible with
>>> ("dvipng --follow -D %D -T tight -bg Transparent --depth --height -o
>>> %B-%%09d.png %f")
>>> I think we should use %O placeholder to pass the correct file name
>>> rather than forcing "%B-%%09d.png".
>>
>> %O will not work, we generate multiple images in one LaTeX run and so we
>> need the -%%09d field to specify the numbering to dvipng.
>>
>> The LaTeX and dvipng process filters then match up the input LaTeX
>> fragments (numbered internally the same way) with the output PNG files.
>>
>> Explicit numbering is required because some images will fail to be
>> generated, and we will get off-by-one and other index errors when
>> matching the input fragment ↔ output image otherwise.
>>
>> What should I do here about the compatibility? It seems like it should
>> be okay to break this.
Still the same comment.
%O is "absolute output file name"
There is nothing stopping us from
doing spec =
(?O . ,(shell-quote-argument
(concat (expand-file-name texfile-base temporary-file-directory)
"%09d.png"))
>>>> (define-obsolete-function-alias
>>>> 'org-clear-latex-preview 'org-latex-preview-clear-overlays "9.7")
>>>
>>> We should then also get rid of
>>> (define-obsolete-function-alias 'org-remove-latex-fragment-image-overlays
>>> 'org-clear-latex-preview "9.3")
>>> That's now super-obsolete.
>>
>> Removed.
>
> I do not see it in git, but note that we also need to announce the
> removal in news.
I see it on git now, but still need to announce in the news.
>>>> (define-obsolete-function-alias
>>>> 'org--get-display-dpi 'org-latex-preview--get-display-dpi "9.7")
>>>
>>> This is redundant. There is no need to obsolete internal functions.
>>
>> I believe I kept this in because some external packages (like PDF tools)
>> were using it. But I have removed it now.
If PDF tools is still using it, we can keep it. But add a commend why we
do it.
>> I've fixed the mentions of the old names except in org-compat.
>
> Pending.
I can see it now.
>>>> (define-obsolete-function-alias
>>>> 'org-latex-mathml-directory 'org-mathml-export-directory "9.8")
>>>
>>> Obsoletion not announced in the news.
>>> Also, org-mathml-export-directory is ignored in the new code.
>>
>> I haven't fixed this. I'm not familiar with this code, not sure what
>> the idea is here. I'll ask Timothy.
Please also note an email from Jacob. ox-odt creates links to files
generated by ox-mathml. If those files are in temporary directory, we
are breaking ox-odt.
>>>> ;; (eval-after-load 'ox-odt '(ad-deactivate 'org-format-latex-as-mathml))
>>>
>>> There is a mention of now-obsolete `org-format-latex-as-mathml'. We can
>>> probably remove that comment. We may also review why that comment is
>>> there and possibly fix the issue (optional).
>>
>> I've removed the comment.
>
> Pending.
This is in git now.
>>>> (make-obsolete-variable
>>>> 'org-preview-latex-image-directory 'org-latex-preview-cache "9.7")
>>>
>>> The new default value is 'persist, which will break obsolete functions.
>>
>> Changed to
>>
>> (make-obsolete-variable
>> 'org-preview-latex-image-directory
>> "Use `org-latex-preview-cache' instead."
>> "10.0")
>>
>> IIUC, now there won't be a clash with the default value of
>> org-latex-preview-cache.
>
We need to remove earlier obsoletion here as well:
(define-obsolete-variable-alias 'org-latex-preview-ltxpng-directory
'org-preview-latex-image-directory "9.0")
(and announce in the news)
Also,
| ~org-preview-latex-image-directory~ | ~org-latex-preview-cache~ |
in the news is no longer accurate. Please update that table and update
the news according to the new reshuffling of obsolete alias vs. obsolete
variable.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
