Ihor Radchenko <yanta...@posteo.net> writes: > Björn Bidar <bjorn.bi...@thaodan.de> writes: > >> +*** =org-link-gnus= Ensure that other frame is alive before selecting it >> +Ensure that the Gnus frame is alive before selecting it if it was >> +activated before. Call ~gnus-other-frame~ in case it >> +was used to call Gnus before, i.e. if ~gnus-other-frame-object~ is >> +not ~nil~. The side effect of that is that the original Gnus frame >> +is reused when the frame is setup instead of being replaced >> +when Gnus was activated using ~gnus~ instead ~gnus-other-frame~ >> +as it should when there is a Gnus frame. > > This is confusing. > What we need to say in the news is (1) what changed; (2) whether users > need to act. > > The current wording does not clearly highlight what has been changed. > Explaining the internal logic is not very helpful, IMHO.
I now adjusted the wording to explain what has changed without explain how. >> +Existing ~org-link-frame-setup~ functions for Gnus links have >> +to be adjusted to ensure that ~gnus-other-frame-object~ contains >> +a frame which is alive. Check the default ~org-gnus-no-news~ >> +function for more. > > Do they really have to be adjusted? If ~gnus-other-frame-object~ is nil, > isn't the new code going to work as earlier? Or do I misunderstand something? If ~gnus-other-frame-object~ is nothing has to be changed but if isn't nil but contains a dead frame than the function would have to be adjusted to also call gnus-other-frame to reactivate the frame. Without that Org-mode can't activate the frame it to be able to show the Summary containing the linked article's group. >> +*** ~org-link-frame-setup~ include new option to open Gnus in other frame >> +Include ~org-gnus-no-new-news-other-frame~ as an option to always >> +call Gnus using ~gnus-other-frame~ regardless if it had been previously >> +used or not. The function can be useful in a frame orientated setup. > > I'd put this into "new funcstions" section, highlighting the new > ~org-gnus-no-new-news-other-frame~ function and only telling that it can > be used within ~org-link-frame-setup~ in detailed explanation. OK. Does that mean that the new possible option for org-link-frame-setup doesn't have to be hightlighted?
