Björn Bidar <bjorn.bi...@thaodan.de> writes:

>> May it be that `org-link-frame-setup' is configured by the user to use
>> current frame, but the user manually used gnus-other-frame and closed
>> the frame? In my mind, your patch then introduced unexpected behavior.
>
> The `org-link-frame-setup' introduced the first unexpected behavior I
> think since `org-gnus-follow-link' unconditionally uses the previously
> existing frame, going with that opening Gnus outside of the
> gnus-other-frame-object in the frame setup function would go against
> that.
> ...

Ok. Looks like you know what you are doing :)
I am a bit lost in this global state managed by gnus.

In any case, given your arguments, I think that your patch is ok.
However, please add ORG-NEWS entry announcing new custom option.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to