Visuwesh <visuwe...@gmail.com> writes:

>> Visuwesh, do you want to proceed with this part?
>
> Do we only want this for images, or for everything?  Everything entails
> images, all dropped files, dropped image files only, and XDND.

Everything, I think.

> This would warrant a NEWS entry too, right?

Indeed.

> +(defun org-link--normalise-filename (filename &optional absolute-always)
> +  "Return FILENAME as required by the value of `org-link-file-path-type'.
> +When ABSOLUTE-ALWAYS is non-nil, always return an absolute and
> +abbreviated filename."

ABSOLUTE-ALWAYS should not be necessary. The caller may simply let-bind
`org-link-file-path-type'. Alternatively, you may avoid using dynamic
scope and simply pass org-link-file-path-type as the second argument.

Other changes look good.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to