Phil Estival <p...@7d.nz> writes:

>> Does the attached diff fix the problem you are encountering?
>
> Yes it does. Thank you!
>
> But we are losing that previous possibility we had of a
> bi-color display of meta lines, with the second part (past
> the text of a meta line) being of the color of the block.

That's an accidental feature. Just happen to work.

Historically, we always used org-fontifiy-whole-block-delimiter-line = t.
It became optional to fontify the newline to avoid underline extending
too far. See https://yhetil.org/emacs-bugs/83d0hd8ceh....@gnu.org/

Looking at that discussion, it seems that it happened before :extend t
face attribute got introduced into Emacs. Maybe we can get along with
letting users set :extend t/nil in the face itself and deprecating
org-fontify-whole-block-delimiter-line.

> Maybe we can simplify a little the fontification of that
> area now by replacing org-fontify-whole-block-delimiter-line
> with the respective extend attribute instead and introducing
> an other variable.

What do you mean by "introducing another variable"?

> Line 5566 of org.el:
> ;; Fontify the #+begin and #+end lines of the blocks.
>
> A quick reminder of the structure of a block to
> understand what I'm saying next :
> [[#+begin_src] [lang] [switches]][remainder of the line]
> [block]
> [#+end_src][remainder of the line]
>
>  1) Begin/end src have a face inheriting from org-meta-line.
>     They can extend all over the line.
>  2) A block fontification starts on the next line of
>     a begin declaration.
>  3) When a meta line is not extended, the remainder is either:
>    - not fontified (it has no text, it's a default face).
>    - or, optionally, it is fontified like a block.
>      This, without identifying if the block fontification
>      should starts right past the meta-line text or at eol,
>      but simply, when set and not extending, adding the
>      extra strike of marker along the line.
>
>     => Introduces org-block-fontify-meta-line
>     (Non-nil means fontify past the text of begin/end
>     lines of blocks with the block face to give the
>     allure of a block covering those lines too.)
>
> Adding a face for the remainder of the line would also
> achieve the same result and even more for the area aspects.

So, you want [remainder of the line] to be fontified differently from
the rest of the #+begin_src ...?

> To me it's fine in the current state. My proposals are only
> meant for someone who would observe the change differently.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to