Hi Bastien and all, >> Subject: [PATCH 1/2] org: Fix corner case for org-kill-line >> >> * lisp/org.el (org-kill-line): Kill _all_ tags when the cursor is on the >> tags part. > > There is a problem with this patch: when on a empty heading with tags, > killing the tags will let the cursor back right after the last "*". > Not a big deal in most headlines, but when on the first headline, this > leads to an error.
Okay. Thanks for this finding. > I think org-kill-line should not try to do too much, and kill only > parts of the tags when the cursor is in the middle of tags is the > right thing to do. Fair enough. I tried to implement the sentence "When after the headline text, kill the tags" from the documentation for org-special-ctrl-k, which I interpreted as kill _all_ tags. Just to make clear my decision for the patch. > As for the other patch, I think it's important to explain that the > whole subtree will be killed, even if not visible -- that's the whole > point of this variable after all. AFAICS the kill of a folded (invisible) subtree is also performed without having set org-special-ctrl-k. So I'd rather say that there is no need for pointing out that behavior in the documentation. > So I'm sorry but these patches can't make it. > > Thanks anyway! You are welcome. That's fine with me. Ciao!
