Hello, Kyle Meyer <k...@kyleam.com> writes:
> Yeah, in order to make org-sort-entries, org-sort-list, and > org-table-sort-lines behave the same way with respect to how they read > getkey-func and compare-func, I ignored the warning in > called-interactively-p's docstring that says it can be "brittle" if a > function is advised or being debugged. > > Instead of adding called-interactively-p to org-sort-entries and > org-sort-list, I initially looked at removing called-interactively-p > from org-table-sort-lines, but I think that would 1) require changing > its behavior for determining the sorting column, and 2) going against > org-table-sort-lines's docstring that says no prompting will take place > if called from Lisp. > > So I'm fine removing called-interactively-p from org-table-sort-lines, > but I'm not sure how it should behave, particularly with respect to the > column prompt. > > Thoughts? Couldn't we use (interactive "p") instead, as suggested in `called-interactively-p' docstring, in order to tell if we need to ask for a function or not? Regards, -- Nicolas Goaziou
