Nicolas Goaziou <m...@nicolasgoaziou.fr> writes: > Jonas Bernoulli <jo...@bernoul.li> writes: > >> Nicolas Goaziou <m...@nicolasgoaziou.fr> writes: >> >>> Jonas Bernoulli <jo...@bernoul.li> writes: >>> >>>> Thanks. But could you please change it to >>>> >>>> (if (or outline-minor-mode orgstruct-mode) >>>> (call-interactively #'show-children) >>>> ...) >>> >>> You could set `orgstruct-mode' to a non-nil value whenever >>> `outline-minor-mode' is enabled. >> >> I could (instead I am currently just maintaining a local patch), >> but what is the reasoning for not just doing what I suggested? > > There is no reason for Org's core to know about `outline-minor-mode', or > any other minor mode in the wild.
I wouldn't group `outline-minor-mode' among "any other minor mode in the wild", after all it was Outline which gave birth to Org and `outline-minor-mode' is part of `outline.el'. Didn't Carsten write `outline-magic.el' (containing `outline-cycle') before moving on to greater things? Unfortunately though `outline-magic.el' does not appear to have aged so well (at least that's how I remember it from when I last checked). Anyway I think `outline-minor-mode' deserves some special attention, but of course that's the call of the maintainers. > IMO, using a hook is much more simple than maintaining a local patch. Not for me. I install all packages using Git submodules, which is very convenient because I contribute to most packages I use, at least in some minor way like addressing compilation warnings. If a patch isn't accepted upstream, then the only additional work required is to call `git config branch.master.rebase true' once and then occasionally `git push tarsius master'.
