On 09/07/2026 11:15, Boris Brezillon wrote:
On Thu, 9 Jul 2026 11:05:52 +0100
Tvrtko Ursulin <[email protected]> wrote:
On 03/07/2026 16:00, Steven Price wrote:
On 02/07/2026 15:37, Tvrtko Ursulin wrote:
After calling drm_sched_job_cleanup(), the free job callback releases it's
NIT: s/it's/its/
reference to the job, where the act of dropping the last reference will
also call the drm_sched_job_cleanup() helper.
We can therefore remove the redundant call from the .free_job callback.
But we have to leave the "if (job->base.s_fence)" guard in job_release(),
since that one not only handles the above described double cleanup, but
also deals with all job cleanup paths which happen before the point the
job was armed.
Signed-off-by: Tvrtko Ursulin <[email protected]>
Cc: Boris Brezillon <[email protected]>
Cc: Liviu Dudau <[email protected]>
Cc: Steven Price <[email protected]>
I agree this looks redundant.
Reviewed-by: Steven Price <[email protected]>
Thank you!
Can this patch be picked up and merged on it's own and who can do it?
Not sure if there is any CI for panthor it maybe needs to pass first.
Nope, we don't. Feel free to queue this to drm-misc-next (with the
type fixe), otherwise Steve or I will queue it at some point.
Pushed to drm-misc-next, thank you!
Regards,
Tvrtko
