Hi Biju, On Tue, 17 Mar 2026 12:36:00 +0000 Biju <[email protected]> wrote:
> From: Biju Das <[email protected]> The commit message seems confusing to me, indicating that you only changed fsleep, but did not change the delay? Maybe change it to indicate that you increase the delay from 1us to 1ms, which is the real reason of the change (why). > > Replace udelay(1) with fsleep(1000) in rzg2l_mipi_dsi_dphy_init() to Same here, the real reason of the change is to increase the delay, and this is not obviously stated. > follow the power-on sequence described in Figure 34.5 of section > "34.4.2.1 Reset" of the RZ/G2L hardware manual Rev.1.50 May 2025. > > Signed-off-by: Biju Das <[email protected]> > --- > drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > index a87a301326c7..e53b48e4de56 100644 > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c > @@ -528,7 +528,7 @@ static int rzg2l_mipi_dsi_dphy_init(struct rzg2l_mipi_dsi > *dsi, > if (ret < 0) > return ret; > > - udelay(1); > + fsleep(1000); > > return 0; > } > -- > 2.43.0 > > -- Hugo Villeneuve <[email protected]>
