On Thu, Feb 4, 2016 at 4:38 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote: > On 4 February 2016 at 15:51, Alex Deucher <alexdeucher at gmail.com> wrote: >> On Thu, Feb 4, 2016 at 10:47 AM, Emil Velikov <emil.l.velikov at gmail.com> >> wrote: >>> On 4 February 2016 at 14:59, Alex Deucher <alexdeucher at gmail.com> wrote: >>>> So it can be shared for CP tests. >>>> >>>> Reviewed-by: Ken Wang <Qingqing.Wang at amd.com> >>>> Signed-off-by: Alex Deucher <alexander.deucher at amd.com> >>>> --- >>>> tests/amdgpu/basic_tests.c | 27 +++++++++++++++++---------- >>>> 1 file changed, 17 insertions(+), 10 deletions(-) >>>> >>>> diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c >>>> index 7806be7..701ccf1 100644 >>>> --- a/tests/amdgpu/basic_tests.c >>>> +++ b/tests/amdgpu/basic_tests.c >>>> @@ -57,6 +57,7 @@ static void >>>> amdgpu_test_exec_cs_helper(amdgpu_context_handle context_handle, >>>> struct amdgpu_cs_request >>>> *ibs_request); >>>> static void amdgpu_command_submission_write_linear_helper(unsigned >>>> ip_type); >>>> static void amdgpu_command_submission_const_fill_helper(unsigned ip_type); >>>> +static void amdgpu_command_submission_copy_linear_helper(unsigned >>>> ip_type); >>>> >>> Unless I'm missing something we don't need these three ? >> >> They are used by patches 3, 5, and 7. >> > You're absolutely correct. I forgot that the amdgpu tests keep the > brief functions at the top (one-online wrappers, test list). Sorry > about the noise.
No worries. I thought about moving the implementations up, but this was less code churn. Alex
