Hi Tony,

Thanks a lot for your very valuable feedback.

On Jan 16, 2014, at 3:27 PM, Tony Finch <d...@dotat.at> wrote:

> Paul Vixie <p...@redbarn.org> wrote:
> 
>> speaking for the authors of the draft below, i request adoption by
>> dnsop. --vixie
>> 
>> https://datatracker.ietf.org/doc/draft-dulaunoy-kaplan-passive-dns-cof/
> 
> A few questions / comments:
> 
> The ws non-terminal isn't defined. I guess it is supposed to be
> 
>       ws = *( %x10 / %x09 )
> 
I agree. You probably meant 

   ws              = *(
                       %x20 |              ; Space
                       %x09                ; Horizontal tab
                      )

?

> i.e. no newlines within a JSON object, which is different from the
> definition of ws in RFC 4627. (Maybe use core ABNF WSP instead?)
> 
Fixed , thanks for pointing this out.

> The ABNF specifies that the field names are not quoted (the quotes are
> part of the ABNF metasyntax not part of the language it specifies) which
> is incompatible with JSON and disagrees with the examples in the appendix.
> 
Fixed

> The appendix could do with some rubric to explain the backslashes.
> 
Fixed

> Are numeric rrtypes represented as JSON numbers? Or a "TYPEnnn" string?
> 
JSON numbers

> I guess time stamps are represented as JSON numbers.
> 
Yes

> How are sensor_id octet strings encoded as JSON strings?
> 
Correct.


So, the changes are currently in our github repository. Waiting for Alexandre 
to submit them again.

See you next week.

a.

> Tony.
> -- 
> f.anthony.n.finch  <d...@dotat.at>  http://dotat.at/
> Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.
> Rough, becoming slight or moderate. Showers, rain at first. Moderate or good,
> occasionally poor at first.
> _______________________________________________
> DNSOP mailing list
> DNSOP@ietf.org
> https://www.ietf.org/mailman/listinfo/dnsop

--- 
// L. Aaron Kaplan <kap...@cert.at> - T: +43 1 5056416 78
// CERT Austria - http://www.cert.at/
// Eine Initiative der nic.at GmbH - http://www.nic.at/
// Firmenbuchnummer 172568b, LG Salzburg




Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

_______________________________________________
DNSOP mailing list
DNSOP@ietf.org
https://www.ietf.org/mailman/listinfo/dnsop

Reply via email to