Libspdm also depends on openssl. We did not want to clone openssl twice. I though stuart config specifies which submodules to clone. Can’t we skip all the submodules within libspdm to fix CI?
Can't devs choose to not use --recursive? Mike > -----Original Message----- > From: Michael Kubacki <mikub...@linux.microsoft.com> > Sent: Wednesday, May 22, 2024 3:16 PM > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kin...@intel.com>; > Yao, Jiewen <jiewen....@intel.com> > Subject: Re: [edk2-devel] libspdm Breaking Builds > > I don't think that's a very good solution given the diversity of > downstream projects dependent on the repo or even for the libspdm repo > itself. > > Thanks, > Michael > > On 5/22/2024 5:57 PM, Michael D Kinney wrote: > > This was discussed and the decision was made to no use recursive clone on > libspdm. > > > > Mike > > > >> -----Original Message----- > >> From: Michael Kubacki <mikub...@linux.microsoft.com> > >> Sent: Wednesday, May 22, 2024 1:40 PM > >> To: devel@edk2.groups.io; Yao, Jiewen <jiewen....@intel.com> > >> Cc: Kinney, Michael D <michael.d.kin...@intel.com> > >> Subject: libspdm Breaking Builds > >> > >> Recently, the libspdm submodule was added to SecurityPkg > >> (SecurityPkg/DeviceSecurity/SpdmLib/libspdm) [1]. > >> > >> That submodule points to https://github.com/DMTF/libspdm.git. > >> > >> The libspdm repo contains a submodule for cmocka that is hosted on > >> cryptomilk.org [2]. > >> > >> Cloning that submodule is failing today, breaking all builds/CI > >> dependent on SecurityPkg. > >> > >> This has been an issue in the past and it is very disruptive given the > >> number of dependencies on edk2/SecurityPkg. Because of its reliability > >> issues, edk2 moved to a version of the repo hosted in tianocore [3] in > >> 2021 [4] > >> > >> Can you please make a similar change in libspdm and we get edk2 updated > >> as soon as possible? > >> > >> Thanks, > >> Michael > >> > >> [1] > >> > https://github.com/tianocore/edk2/commit/54a4fd9b35cac79e7c54b750d3dddd0fbb43 > >> dca1 > >> > >> [2] https://github.com/DMTF/libspdm/blob/main/.gitmodules > >> > >> [3] https://github.com/tianocore/edk2-cmocka > >> > >> [4] > >> > https://github.com/tianocore/edk2/commit/2ad22420a710dc07e3b644f91a5b55c09c39 > >> ecf3 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119121): https://edk2.groups.io/g/devel/message/119121 Mute This Topic: https://groups.io/mt/106250971/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
