Looks fine to me. While it's not necessary to add a default value PCD to every platform DSC, it might me a good idea to do so for "example" platforms like RiscVVirt, so that folks who borrow code are aware of the feature?
Reviewed-by: Andrei Warkentin <andrei.warken...@intel.com> > -----Original Message----- > From: Dhaval <dha...@rivosinc.com> > Sent: Sunday, October 29, 2023 9:46 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>; Yao, Jiewen > <jiewen....@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; Gerd > Hoffmann <kra...@redhat.com>; Sunil V L <suni...@ventanamicro.com>; > Warkentin, Andrei <andrei.warken...@intel.com>; Laszlo Ersek > <ler...@redhat.com> > Subject: [PATCH v7 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features > > This PCD provides a way for platform to override any HW features that are > default enabled by previous stages of FW (like OpenSBI). For the case where > previous/prev stage has disabled the feature, this override is not useful and > its usage should be avoided. > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Sunil V L <suni...@ventanamicro.com> > Cc: Andrei Warkentin <andrei.warken...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > > Signed-off-by: Dhaval Sharma <dha...@rivosinc.com> > Acked-by: Laszlo Ersek <ler...@redhat.com> > --- > > Notes: > V7: > - Added RB tag > v6: > - Modify PCD name according to changes made in Baselib implementation > V5: > - Introduce PCD for platform > > OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > index fe320525153f..5d66f7fe6ae6 100644 > --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > @@ -203,6 +203,7 @@ [PcdsFeatureFlag] > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > [PcdsFixedAtBuild.common]+ > gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0 > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0-- > 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110362): https://edk2.groups.io/g/devel/message/110362 Mute This Topic: https://groups.io/mt/102256471/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
