On 10/18/23 13:21, 蔡雨晴 wrote: > Hi Laszlo, > > Thank you for your comments. I will commit a new patch to add the > maintainers to the "Maintainers.txt" file in the root directory of the > edk2-platforms project. > > Please let us know if you have more suggestions.
I do have one, but it's not specifically for this patch set, but for all future edk2(-platforms) patches you may post -- please add "--stat=1000 --stat-graph-width=20" to your git-format-patch command line. Edk2(-platforms) use(s) long pathnames, and so the cumulative diffstat tends to be truncated, and on the left side at that. That fact makes it hard to see the extent of a patchset. If you add these options, then the cumulative diffstat is going to be just as wide as it needs to be -- no truncation, and no needless padding. The "BaseTools/Scripts/SetupGit.py" utility creates a git-format-patch alias called "fp" that includes these options. BTW I could help Ard out by pushing this patch set (well, v4, with the Maintainers.txt fix), I'm just not clear when a patch set counts as "sufficiently reviewed" for edk2-platforms. Laszlo > > Thanks, > Yuqing Cai > > > > > > At 2023-10-18 17:47:04, "Laszlo Ersek" <ler...@redhat.com> wrote: >>On 10/13/23 05:03, caiyuqing...@163.com wrote: >>> diff --git a/Platform/Sophgo/Maintainers.md b/Platform/Sophgo/Maintainers.md >>> new file mode 100644 >>> index 000000000000..4cb32c359a31 >>> --- /dev/null >>> +++ b/Platform/Sophgo/Maintainers.md >>> @@ -0,0 +1,105 @@ >>> +##Project Name: EDK2 Sophgo SG2042 >>> + >>> +##Maintainers: >>> +1. dahogn - dah...@hotmail.com >>> +2. caiyuqing379 - <caiyuqing...@outlook.com> >>> +3. meng-cz - mengcz1...@gmail.com >>> +4. USER0FISH - <libing1...@outlook.com> >>> + >> >>This "Platform/Sophgo/Maintainers.md" file / format is useless with >>edk2's "BaseTools/Scripts/GetMaintainer.py" utility. For that utility to >>work, you need to add the maintainers to the "Maintainers.txt" file in >>the edk2-platforms project root dir (... as well). >> >>Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109740): https://edk2.groups.io/g/devel/message/109740 Mute This Topic: https://groups.io/mt/101944473/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
